klsince commented on code in PR #10722:
URL: https://github.com/apache/pinot/pull/10722#discussion_r1186525421
##########
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/StartReplaceSegmentsRequest.java:
##########
@@ -39,6 +40,12 @@ public class StartReplaceSegmentsRequest {
private final List<String> _segmentsTo;
private final Map<String, String> _customMap;
+ public StartReplaceSegmentsRequest(@JsonProperty("segmentsFrom") @Nullable
List<String> segmentsFrom,
+ @JsonProperty("segmentsTo") @Nullable List<String> segmentsTo) {
+ this(segmentsFrom, segmentsTo, null);
+ }
+
+ @JsonCreator
public StartReplaceSegmentsRequest(@JsonProperty("segmentsFrom") @Nullable
List<String> segmentsFrom,
Review Comment:
looks like the existing constructor already accepts all parameters required
by the new one you added. why not just use this existing constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
