walterddr commented on code in PR #10739:
URL: https://github.com/apache/pinot/pull/10739#discussion_r1188919302
##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -3223,5 +3231,22 @@ public void testJoin() {
Assert.assertEquals(rightSubquery,
CalciteSqlParser.compileToPinotQuery("SELECT key, COUNT(*) AS b FROM
T3 JOIN T4 GROUP BY key"));
Assert.assertEquals(join.getCondition(),
CalciteSqlParser.compileToExpression("T1.key = T2.key"));
+
+ // test for self join queries
+ query = "SELECT T1.a FROM T1 JOIN(SELECT key FROM T1) as self ON
T1.key=self.key";
Review Comment:
^ in this case doesnt the AS T2 test already covered this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
