walterddr commented on code in PR #10744:
URL: https://github.com/apache/pinot/pull/10744#discussion_r1188964395
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -93,6 +93,10 @@ public PinotMetricsRegistry getMetricsRegistry() {
public interface QueryPhase {
String getQueryPhaseName();
+
+ default String getDescription() {
+ return "";
+ }
Review Comment:
why do we need the default behavior if the constructor is already catching
and setting `""` ? ( are we concern backward-compatibility for other
extensions?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
