abhioncbr commented on code in PR #10765:
URL: https://github.com/apache/pinot/pull/10765#discussion_r1193065738
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -386,14 +391,22 @@ protected void addTableToH2(String tableName, Schema
schema)
h2FieldNamesAndTypes.toArray(new String[h2FieldNamesAndTypes.size()]))
+ ")").execute();
}
+ private String getH2InsertQueryParam(String h2FieldNameAndType) {
+ String type = h2FieldNameAndType.split(" ")[1];
+ if ("json".equalsIgnoreCase(type)) {
+ return "? FORMAT JSON";
Review Comment:
This is needed for the comparison with Pinot rows. As per the
[documentation](https://www.h2database.com/html/datatypes.html#json_type), this
will save the data in `java.lang.String` format in H2 db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
