xiangfu0 commented on code in PR #10764:
URL: https://github.com/apache/pinot/pull/10764#discussion_r1194308329
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SetOperator.java:
##########
@@ -112,36 +110,29 @@ protected void constructRightBlockSet() {
}
block = _rightChildOperator.nextBlock();
}
- _isRightBlockConsumed = true;
+ _isRightSetBuilt = true;
}
- protected TransferableBlock constructResultBlockSet() {
- _resultRowBlock.clear();
- // First time initialization.
- if (_currentLeftBlock == null) {
- _currentLeftBlock = _leftChildOperator.nextBlock();
+ protected TransferableBlock constructResultBlockSet(TransferableBlock
leftBlock) {
+ List<Object[]> rows = new ArrayList<>();
+ if (leftBlock.isErrorBlock()) {
+ _upstreamErrorBlock = leftBlock;
+ return _upstreamErrorBlock;
}
- while (!_currentLeftBlock.isEndOfStreamBlock()) {
- if (_currentLeftBlock.getType() == DataBlock.Type.METADATA) {
- _currentLeftBlock = _leftChildOperator.nextBlock();
- continue;
+ if (leftBlock.isNoOpBlock() || leftBlock.isSuccessfulEndOfStreamBlock()) {
+ if (!leftBlock.getResultMetadata().isEmpty()) {
Review Comment:
why empty code block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
