walterddr commented on code in PR #10756:
URL: https://github.com/apache/pinot/pull/10756#discussion_r1195430392
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -212,7 +212,8 @@ public static DistributedStagePlan
constructDistributedStagePlan(DispatchableSub
int stageId, VirtualServerAddress serverAddress) {
return new DistributedStagePlan(stageId, serverAddress,
dispatchableSubPlan.getQueryStageList().get(stageId).getPlanFragment().getFragmentRoot(),
-
dispatchableSubPlan.getQueryStageList().get(stageId).toStageMetadata());
+
StageMetadata.from(dispatchableSubPlan.getQueryStageList().get(stageId)),
Review Comment:
the right way to solve this is do not construct `DistributedStagePlan` on
broker. instead construct the proto object directly and when deserialize, put
them into multiple `DistributedStagePlan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
