walterddr commented on code in PR #10790:
URL: https://github.com/apache/pinot/pull/10790#discussion_r1201461100
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -239,6 +239,7 @@ private static TransferableBlock
composeSelectTransferableBlock(InstanceResponse
+ " Column Ordering: " + Arrays.toString(columnIndices));
return composeColumnIndexedTransferableBlock(responseBlock,
adjustedResultSchema, columnIndices);
} else {
+ handleBytesDataType(desiredDataSchema.getColumnDataTypes(),
resultSchema.getColumnDataTypes());
Review Comment:
handling this here is wrong IMO. b/c both column index reordering and direct
transferrable had to handle bytes type. you can add the logic in
`canonicalizeRow` method IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
