gortiz commented on code in PR #10528:
URL: https://github.com/apache/pinot/pull/10528#discussion_r1211336807
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##########
@@ -138,28 +140,28 @@ public void testServerHardFailure()
// Take a server and shut down its query server to mimic a hard failure
BaseServerStarter serverStarter = _serverStarters.get(NUM_SERVERS - 1);
- serverStarter.getServerInstance().shutDown();
-
- // First query should hit all servers and get connection refused exception
- testCountStarQuery(NUM_SERVERS, true);
-
- // Second query should not hit the failed server, and should return the
correct result
- testCountStarQuery(NUM_SERVERS - 1, false);
-
- // Restart the failed server, and it should be included in the routing
again
- serverStarter.stop();
- serverStarter = startOneServer(NUM_SERVERS - 1);
- _serverStarters.set(NUM_SERVERS - 1, serverStarter);
- TestUtils.waitForCondition(aVoid -> {
- try {
+ try {
+ serverStarter.getServerInstance().shutDown();
+
+ // First query should hit all servers and get connection refused or
reset exception
+ // TODO: This is a flaky test. There is a race condition between
shutDown and the query being executed.
Review Comment:
Created: https://github.com/apache/pinot/issues/10823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
