Jackie-Jiang commented on code in PR #10819:
URL: https://github.com/apache/pinot/pull/10819#discussion_r1212383911
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxReceiveNode.java:
##########
@@ -65,15 +69,26 @@ public MailboxReceiveNode(int planFragmentId, DataSchema
dataSchema, int senderS
_exchangeType = exchangeType;
_partitionKeySelector = partitionKeySelector;
if (!CollectionUtils.isEmpty(fieldCollations)) {
- _collationKeys = new ArrayList<>(fieldCollations.size());
- _collationDirections = new ArrayList<>(fieldCollations.size());
+ int numCollations = fieldCollations.size();
+ _collationKeys = new ArrayList<>(numCollations);
+ _collationDirections = new ArrayList<>(numCollations);
+ _collationNullDirections = new ArrayList<>(numCollations);
for (RelFieldCollation fieldCollation : fieldCollations) {
- _collationDirections.add(fieldCollation.getDirection());
_collationKeys.add(new
RexExpression.InputRef(fieldCollation.getFieldIndex()));
+ Direction direction = fieldCollation.getDirection();
+ Preconditions.checkArgument(direction == Direction.ASCENDING ||
direction == Direction.DESCENDING,
+ "Unsupported ORDER-BY direction: %s", direction);
Review Comment:
There are other direction enums (`STRICTLY_ASCENDING`,
`STRICTLY_DESCENDING`, `CLUSTERED`) that we don't support yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
