klsince commented on code in PR #10837:
URL: https://github.com/apache/pinot/pull/10837#discussion_r1214941838
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -691,9 +691,10 @@ File getSegmentDataDir(String segmentName, @Nullable
String segmentTier, TableCo
File tierTableDataDir = new File(tierDataDir, _tableNameWithType);
return new File(tierTableDataDir, segmentName);
} catch (Exception e) {
- LOGGER.warn("Failed to get dataDir for segment: {} of table: {} on tier:
{} due to error: {}", segmentName,
- _tableNameWithType, segmentTier, e.getMessage());
- return getSegmentDataDir(segmentName);
+ File defaultDir = getSegmentDataDir(segmentName);
+ LOGGER.debug("Failed to get dataDir for segment: {} of table: {} on
tier: {} due to error: {}. Use default: {}",
Review Comment:
It's common, e.g. a table has multi tiers backed by different server pools
and those servers simply use the default dataDir to load segments via
DefaultSegmentDirectoryLoader, i.e. no particular data path defined for those
tiers.
But this is exception for TierBasedSegmentDirectoryLoader, which expects
tier is backed by a data path and it logs a warn log itself. Because this is in
BaseTableDataManager class, so make this a debug log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
