gortiz commented on PR #9416: URL: https://github.com/apache/pinot/pull/9416#issuecomment-1577689769
> If we use Compound metrics registry, would the prometheus storage double? That depends on our Prometheus config. We could configure Prometheus to store one set of the metrics or both. In the latter case the storage would be doubled. > And in the end where you give example of what we can set in pattern with Dropwizard, what should we set to catch separately, if we are using Compound? I think we should not use Compound in actual deployments. It may be useful to use that in a integration test in order to verify that both metric registries are actually returning compatible information and that we can create the same Prometheus metrics from one or the other. In case we want to actually use Compound and we want to register both metrics in Prometheus, we would need to have two rules per metric. One can be the same we have right now (which is going to read from Yammer) and then we can add another like: ``` - pattern: "org.apache.pinot.common.metrics<name=\"pinot.broker.([^\\.]*?)\\.totalServerResponseSize\"><>(\\w+)" ``` The latter will only match with Dropwizard because the domain does not start with `\"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
