egalpin commented on code in PR #10841:
URL: https://github.com/apache/pinot/pull/10841#discussion_r1220487877
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java:
##########
@@ -642,4 +1138,30 @@ public static long timestampDiff(String unit, long
timestamp1, long timestamp2)
ISOChronology chronology = ISOChronology.getInstanceUTC();
return DateTimeUtils.getTimestampField(chronology,
unit).getDifferenceAsLong(timestamp2, timestamp1);
}
+ @ScalarFunction(names = {"timestampDiffMVMV", "dateDiffMVMV"})
+ public static long[] timestampDiffMVMV(String unit, long[] timestamp1,
long[] timestamp2) {
Review Comment:
Agreed haha. I removed the `MVMV` variant altogether in
https://github.com/apache/pinot/pull/10841/commits/39a2fcdad5489ed5bdfdcd095c9c77ffd90d0380
because I think it would be prone to error (users relying on ordering of MV
columns).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
