navina commented on PR #10836:
URL: https://github.com/apache/pinot/pull/10836#issuecomment-1581226541
> `comparisonColumn` might not be set in the upsert config, and we want to
use time column as the comparison column if it is not configured. If we pass
the `UpsertConfig` to the partition level metadata manager, we need to apply
the same logic again for each partition
I see. And looks like we don't have access to the time column in the code
paths since it comes from schema? crap.
Ok internal wrapper class is one option. an alternative could also be to
re-create a new instance with the comparison column set. The latter will
prevent future misuse of the `UpsertConfig` class by preventing mutability
after config object creation. This is my 2 cents.
Thanks for clarifying @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
