ankitsultana opened a new pull request, #10892: URL: https://github.com/apache/pinot/pull/10892
As part of graceful shutdown, we wait for each consumer thread to stop. If a segment is committing, we will wait for the commit to finish before continuing with the shutdown (assuming commit happens within the grace period). At present after the `SegmentCommitter` returns success, we call `replaceLLSegment` which makes a ZK call. However, as part of graceful shutdown we stop the HelixManager before destroying the segment data managers so the ZK client is already closed. We don't need to refetch the table-config and schema because they are already present in the segment data manager and this PR essentially makes that change. The goal is to ensure the commit completes cleanly during server shutdown. cc: @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
