Jackie-Jiang commented on code in PR #10895:
URL: https://github.com/apache/pinot/pull/10895#discussion_r1227219879
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClientConfig.java:
##########
@@ -61,6 +68,10 @@ public static Builder newBuilder(PinotConfiguration
pinotConfiguration) {
if (StringUtils.isNotEmpty(maxConnsPerRoute)) {
builder.withMaxConnsPerRoute(Integer.parseInt(maxConnsPerRoute));
}
+ boolean disableDefaultUserAgent =
pinotConfiguration.getProperty(DISABLE_DEFAULT_USER_AGENT_CONFIG_NAME, false);
+ if (disableDefaultUserAgent) {
+ builder.withDisableDefaultUserAgent(true);
+ }
Review Comment:
```suggestion
builder.withDisableDefaultUserAgent(disableDefaultUserAgent);
```
##########
pinot-core/src/main/java/org/apache/pinot/server/realtime/ServerSegmentCompletionProtocolHandler.java:
##########
@@ -52,6 +53,7 @@ public class ServerSegmentCompletionProtocolHandler {
private static final String HTTP_PROTOCOL = CommonConstants.HTTP_PROTOCOL;
private static SSLContext _sslContext;
+ private static HttpClientConfig _httpClientConfig =
HttpClientConfig.DEFAULT_HTTP_CLIENT_CONFIG;
Review Comment:
I don't follow the changes in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
