Jackie-Jiang commented on code in PR #10613:
URL: https://github.com/apache/pinot/pull/10613#discussion_r1227401708
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java:
##########
@@ -118,111 +93,181 @@ public int[] getDictionaryIdsSV() {
public int[] getIntValuesSV() {
try (InvocationScope scope =
Tracing.getTracer().createScope(TransformBlockValSet.class)) {
recordTransformValues(scope, DataType.INT, true);
- return _transformFunction.transformToIntValuesSV(_valueBlock);
+ if (!_isNullHandlingEnabled) {
+ return _transformFunction.transformToIntValuesSV(_valueBlock);
+ }
+ Pair<int[], RoaringBitmap> result =
_transformFunction.transformToIntValuesSVWithNull(_valueBlock);
Review Comment:
Should we also add `getIntValuesSVWithNull()` etc so that it is consistent
with transform function behavior (separate the APIs with or without null
handling)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
