tibrewalpratik17 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228718762
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1130,4 +1152,38 @@ private SuccessResponse
updateZKTimeIntervalInternal(String tableNameWithType) {
}
return new SuccessResponse("Successfully updated time interval zk
metadata for table: " + tableNameWithType);
}
+
+ public List<Pair<TableType, List<String>>> selectSegments(
Review Comment:
Are we planning to add UTs for this method? If not, can we make this
`private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]