swaminathanmanish commented on PR #10874: URL: https://github.com/apache/pinot/pull/10874#issuecomment-1589897248
> Since we are modifying this, I'd suggest just cleaning up the old code and always open and close the file within the segment mapper. Keeping both constructors adds a lot of code management overhead Got rid of the _recordReaders field from mapper code, but kept top level constructor for SegmentProcessorFramework. cc @snleee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
