robertzych commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1234328955
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -489,14 +489,16 @@ static void setDefaultTimeValueIfInvalid(TableConfig
tableConfig, Schema schema,
@Override
public void addSegment(ImmutableSegment immutableSegment) {
- if (isUpsertEnabled()) {
- handleUpsert(immutableSegment);
- return;
- }
+ if (immutableSegment instanceof ImmutableSegmentImpl) {
Review Comment:
@Jackie-Jiang If you recall, I mentioned that the integration test was
failing because `RealtimeTableDataManager.handleUpsert` doesn't work with empty
segments. When the compacted segment is empty, the call to
`SegmentUtils.getRealtimeSegmentPartitionId` returns `null` and causes the
precondition to fail.
If this were preventing the original segment from being replaced by the
empty compacted segment, wouldn't the new integration test fail at the point
where it's checking the table's physical record count (skipUpsert=true) after
compaction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
