Jackie-Jiang commented on code in PR #10943:
URL: https://github.com/apache/pinot/pull/10943#discussion_r1237924010
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -557,4 +558,16 @@ public void addToExceptions(QueryProcessingException
processingException) {
public int getExceptionsSize() {
return _processingExceptions.size();
}
+
Review Comment:
(nit) Extra empty line
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java:
##########
@@ -35,6 +36,7 @@ private BrokerResponse() {
}
private BrokerResponse(JsonNode brokerResponse) {
+ _requestId = brokerResponse.get("requestId") != null ?
brokerResponse.get("requestId").asText() : "-1";
Review Comment:
Consider putting "unknown"?
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -557,4 +558,16 @@ public void addToExceptions(QueryProcessingException
processingException) {
public int getExceptionsSize() {
return _processingExceptions.size();
}
+
+
+ @JsonProperty("requestId")
+ @Override
+ public String getRequestId() {
+ return _requestId;
+ }
+
+ @Override
Review Comment:
Also annotate (JsonProperty) the setter? (Although seems the annotation is
redundant)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
