Jackie-Jiang commented on issue #10907: URL: https://github.com/apache/pinot/issues/10907#issuecomment-1612255465
> Would this solution mean that if a user enables Null Values on an existing table they have to configure what columns will support Nulls and then we treat the default value as the null value? This only applies to existing segments (whether the table exist of not doesn't matter). For new segments, null value vector can be properly generated based on whether the input value is null. > What would happen if the user enabled NV support on a table that already exists but they don't configure any columns? New segments will have null value vector properly generated. No changes will happen for existing segments. > What would happen to the already existing segments? In these we would just treat the default value as null? The problem of directly treating the default value as null is that we might mistakenly treat real default value as null. This can be very common for metric columns, where default value is 0. That's the reason why I suggested adding a config for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
