shenyu0127 commented on code in PR #10999:
URL: https://github.com/apache/pinot/pull/10999#discussion_r1246133357
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##########
@@ -178,11 +178,12 @@ private void testCountStarQuery(int
expectedNumServersQueried, boolean exception
JsonNode exceptions = queryResult.get("exceptions");
assertEquals(exceptions.size(), 2);
JsonNode firstException = exceptions.get(0);
+ // NOTE:
+ // Only verify the error code but not the exception message because
there can be different messages:
+ // - Connection refused
+ // - Connection reset
+ // - Channel is inactive
assertEquals(firstException.get("errorCode").intValue(),
QueryException.BROKER_REQUEST_SEND_ERROR_CODE);
- String firstExceptionMessage = firstException.get("message").textValue();
- assertTrue(
- firstExceptionMessage.contains("Connection refused") ||
firstExceptionMessage.contains("Connection reset"),
- "Got unexpected first exception message: " + firstExceptionMessage);
Review Comment:
You are not adding `|| firstExceptionMessage.contains("inactive")` here, is
it because there might be other exception messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
