shenyu0127 commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1247142236
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -43,43 +43,44 @@ public TypeFactory(RelDataTypeSystem typeSystem) {
super(typeSystem);
}
- public RelDataType createRelDataTypeFromSchema(Schema schema) {
+ public RelDataType createRelDataTypeFromSchema(Schema schema, boolean
isNullSupportEnabled) {
Builder builder = new Builder(this);
for (Map.Entry<String, FieldSpec> e : schema.getFieldSpecMap().entrySet())
{
- builder.add(e.getKey(), toRelDataType(e.getValue()));
+ builder.add(e.getKey(), toRelDataType(e.getValue(),
+ isNullSupportEnabled || e.getValue().isNullableField()));
Review Comment:
Or the table level nullability can also be NULL (default). If both the
column level nullability and table level nullability are NULL, we apply the
current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
