walterddr commented on code in PR #10845:
URL: https://github.com/apache/pinot/pull/10845#discussion_r1248121185
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseBooleanAggregationFunction.java:
##########
@@ -233,7 +233,8 @@ public Integer merge(Integer intermediateResult1, Integer
intermediateResult2) {
@Override
public DataSchema.ColumnDataType getIntermediateResultColumnType() {
- return DataSchema.ColumnDataType.BOOLEAN;
+ // The intermediateResult type is integer. The final result is converted
to a boolean.
+ return DataSchema.ColumnDataType.INT;
Review Comment:
this could cause backward-compatibility issue when upgrading. let's make
sure this doesn't cause issues (where is this function being used in v1)
in v2 as long as the expected data type conforms with calcite we are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
