chenboat commented on code in PR #10993:
URL: https://github.com/apache/pinot/pull/10993#discussion_r1248392840
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -260,7 +276,7 @@ private String getTablesServedFromTenant(String tenantName)
{
return resourceGetRet.toString();
}
- private String toggleTenantState(String tenantName, String stateStr,
@Nullable String tenantType) {
+ private SuccessResponse toggleTenantState(String tenantName, String
stateStr, @Nullable String tenantType) {
Review Comment:
toggle means switch between 2 states. But the StateType enum has 3 states.
We should use changeTenantState to reduce the confusion -- unless you can
explain in javadoc why some state is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
