s0nskar commented on code in PR #11057:
URL: https://github.com/apache/pinot/pull/11057#discussion_r1256986968
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/DateTimeConversionTransformFunctionTest.java:
##########
@@ -66,7 +66,7 @@ public Object[][] testIllegalArguments() {
}, new
Object[]{"dateTimeConvert(5,'1:MILLISECONDS:EPOCH','1:MINUTES:EPOCH','1:MINUTES')"},
new Object[]{
String.format("dateTimeConvert(%s,'1:MILLISECONDS:EPOCH','1:MINUTES:EPOCH','1:MINUTES')",
INT_MV_COLUMN)
}, new Object[]{
-
String.format("dateTimeConvert(%s,'1:MILLISECONDS:EPOCH','1:MINUTES:EPOCH','MINUTES')",
TIME_COLUMN)
+
String.format("dateTimeConvert(%s,'1:MILLISECONDS:EPOCH','1:MINUTES:EPOCH','MINUTES:1')",
TIME_COLUMN)
Review Comment:
Fixing failing test, as `MINUTES` was getting considered as a valid
granularity after this diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
