xiangfu0 commented on code in PR #11064:
URL: https://github.com/apache/pinot/pull/11064#discussion_r1257224007
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -119,8 +119,8 @@ public class ControllerTest {
protected static HttpClient _httpClient = null;
- protected int _controllerPort;
- protected String _controllerBaseApiUrl;
Review Comment:
This is more to simplify the usage.
Ideally users shouldn't have to manually assemble those urls for API calls.
Eventually all the usage of `_controllerBaseApiUrl` should go to
`getControllerRequestClient()` or `getControllerRequestURLBuilder`, similar
story should apply to broker usage as well for `_brokerBaseApiUrl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
