walterddr commented on code in PR #11143:
URL: https://github.com/apache/pinot/pull/11143#discussion_r1270124518
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -88,8 +88,12 @@ public enum AggregationFunctionType {
DISTINCTCOUNTRAWHLL("distinctCountRawHLL"),
DISTINCTCOUNTSMARTHLL("distinctCountSmartHLL"),
FASTHLL("fastHLL"),
- DISTINCTCOUNTTHETASKETCH("distinctCountThetaSketch"),
- DISTINCTCOUNTRAWTHETASKETCH("distinctCountRawThetaSketch"),
+ DISTINCTCOUNTTHETASKETCH("distinctCountThetaSketch",
ImmutableList.of("DISTINCT_COUNT_THETA_SKETCH"),
+ SqlKind.OTHER_FUNCTION, SqlFunctionCategory.USER_DEFINED_FUNCTION,
OperandTypes.VARIADIC, ReturnTypes.BIGINT,
Review Comment:
VARIADIC is problematic. we can only run these in v1. i don't know if we
should do this and allow the problematic syntax in v2.
we should only allow
1. single column (1op)
2. single column + theta sketch config (2op)
and not allow the variating filter + set operation in v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
