soumitra-st commented on code in PR #11016:
URL: https://github.com/apache/pinot/pull/11016#discussion_r1271254385
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/extraresources/PinotDummyExtraRestletResource.java:
##########
@@ -26,13 +26,17 @@
import javax.ws.rs.Path;
import javax.ws.rs.Produces;
import javax.ws.rs.core.MediaType;
+import org.apache.pinot.core.auth.Actions;
+import org.apache.pinot.core.auth.Authorize;
+import org.apache.pinot.core.auth.TargetType;
@Api(tags = "testExtra")
@Path("/testExtra")
public class PinotDummyExtraRestletResource {
@GET
+ @Authorize(targetType = TargetType.CLUSTER, action = Actions.Cluster.DUMMY)
Review Comment:
If neither Authorize nor ManualAuthorization is present, then the AUTH call
will go to defaultAuthorization and that may not be allowed. If that is the
case, no user will be able to use this test API. I suggest to keep the
annotation and change the action to Test or Debug, what do you say?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
