sajjad-moradi commented on PR #11166: URL: https://github.com/apache/pinot/pull/11166#issuecomment-1650714624
> I am worried that we may not be able to test all combinations of the case if we post a stopConsume message. Does it still work if Helix has not yet gotten around to set externalview to ERROR state? I believe because we've marked IS as OFFLINE, EV will eventually be OFFLINE. There are two possibilities here [since before throwing exception in handling `OFFLINE->CONSUMING` transition, controller has marked IS as OFFLINE]: - EV goes to ERROR and then Helix tries to match the current state (ERROR) to ideal state (OFFLINE) - Helix tries to match IS and EV before EV goes to ERROR. In this case both IS and EV are OFFLINE, so helix doesn't do anything. In both scenarios, the EV ends up being OFFLINE for the segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
