navina commented on code in PR #11017:
URL: https://github.com/apache/pinot/pull/11017#discussion_r1276648350
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotTableRestletResourceTest.java:
##########
@@ -58,7 +58,8 @@ public class PinotTableRestletResourceTest extends
ControllerTest {
private static final String OFFLINE_TABLE_NAME = "testOfflineTable";
private static final String REALTIME_TABLE_NAME = "testRealtimeTable";
private final TableConfigBuilder _offlineBuilder = new
TableConfigBuilder(TableType.OFFLINE);
- private final TableConfigBuilder _realtimeBuilder = new
TableConfigBuilder(TableType.REALTIME);
+ private final TableConfigBuilder _realtimeBuilder = new
TableConfigBuilder(TableType.REALTIME)
+ .setStreamConfigs(Map.of("stream.type", "foo", "consumer.type",
"lowlevel"));
Review Comment:
Yes. We don't seem to validate stream.type. Is that what you are referring
to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
