abhioncbr commented on code in PR #11218:
URL: https://github.com/apache/pinot/pull/11218#discussion_r1278214257
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreatorTest.java:
##########
@@ -250,6 +253,16 @@ public void testAddMinMaxValue() {
stringMaxValue, FieldSpec.DataType.STRING);
compareLongValuesWithColumnMinMax(stringMinValue, stringMaxValue, props,
FieldSpec.DataType.STRING);
+ // test for value length grater than METADATA_PROPERTY_LENGTH_LIMIT with
random string having ascii characters.
Review Comment:
Added ASCII-based random string to test the scenario if the original values
have characters which need escape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
