gortiz commented on code in PR #11204:
URL: https://github.com/apache/pinot/pull/11204#discussion_r1280421788
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/NativeMutableTextIndex.java:
##########
@@ -63,9 +63,22 @@ public NativeMutableTextIndex(String column) {
@Override
public void add(String document) {
- Iterable<String> tokens;
+ addHelper(document);
+ _nextDocId++;
+ }
+
+ @Override
+ public void add(String[] documents) {
+ for (String document : documents) {
+ addHelper(document);
+ }
+ _nextDocId++;
+ }
+ private void addHelper(String document) {
+ Iterable<String> tokens;
tokens = analyze(document);
+
Review Comment:
nit: Can we merge declaration and assignation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
