Jackie-Jiang commented on code in PR #11234:
URL: https://github.com/apache/pinot/pull/11234#discussion_r1281496972
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/ResourceBasedQueriesTest.java:
##########
@@ -98,51 +101,54 @@ public void setUp()
boolean allowEmptySegment =
!BooleanUtils.toBoolean(extractExtraProps(testCase._extraProps,
"noEmptySegment"));
String tableName = testCaseName + "_" + tableEntry.getKey();
// Testing only OFFLINE table b/c Hybrid table test is a special case
to test separately.
- String tableNameWithType =
TableNameBuilder.forType(TableType.OFFLINE).tableNameWithType(tableName);
- org.apache.pinot.spi.data.Schema pinotSchema =
constructSchema(tableName, tableEntry.getValue()._schema);
+ String offlineTableName =
TableNameBuilder.forType(TableType.OFFLINE).tableNameWithType(tableName);
+ Schema pinotSchema = constructSchema(tableName,
tableEntry.getValue()._schema);
schemaMap.put(tableName, pinotSchema);
- factory1.registerTable(pinotSchema, tableNameWithType);
- factory2.registerTable(pinotSchema, tableNameWithType);
+ factory1.registerTable(pinotSchema, offlineTableName);
+ factory2.registerTable(pinotSchema, offlineTableName);
List<QueryTestCase.ColumnAndType> columnAndTypes =
tableEntry.getValue()._schema;
List<GenericRow> genericRows = toRow(columnAndTypes,
tableEntry.getValue()._inputs);
// generate segments and dump into server1 and server2
List<String> partitionColumns =
tableEntry.getValue()._partitionColumns;
+ String partitionColumn = null;
+ List<List<String>> partitionIdToSegmentsMap = null;
+ if (partitionColumns != null && partitionColumns.size() == 1) {
+ partitionColumn = partitionColumns.get(0);
+ partitionIdToSegmentsMap = new ArrayList<>();
+ for (int i = 0; i < 4; i++) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
