abhioncbr commented on code in PR #11246:
URL: https://github.com/apache/pinot/pull/11246#discussion_r1282598638
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java:
##########
@@ -301,48 +287,6 @@ private static final class SSLContextHolder {
: SSL_CONTEXT_REF.get();
}
- /**
- * Adapted from: https://svn.apache.org/viewvc/httpcomponents/oac
- *
.hc3x/trunk/src/contrib/org/apache/commons/httpclient/contrib/ssl/AuthSSLProtocolSocketFactory.java?view=markup
- */
- private static class PinotProtocolSocketFactory implements
ProtocolSocketFactory {
Review Comment:
imo, it's not getting used. All our test cases are green; however, there
might also be a missing test case scenario.
We have
[HttpClient](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/http/HttpClient.java#L100)
class with `SSLConnectionSocketFactory` which is providing the same
functionality based on `org.apache.httpcomponents`
Based on my understanding, this is the old way of defining the custom HTTPs
connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
