gortiz opened a new pull request, #11283: URL: https://github.com/apache/pinot/pull/11283
This PR includes adds spotbugs execution in the plugin section. The spotbugs configuration ignores all default detectors (we can discuss later if we want to use them in future) but enables a new detector specifically created to detect when we are calling a SPI method using as argument or receiving as result some object defined in a shaded library. Right now the spotbugs plugin includes two simplifications: 1. _calling a SPI_ means calling constructors, static or virtual methods defined in a class whose package starts with `org.apache.pinot.segment.spi` or `org.apache.pinot.spi`. 2. _object defined in a shared library_ means an object whose package starts with `com.fasterxml.jackson` or `com.google.common` This means that this system has false negatives (there are more shaded libraries and there may be more SPI classes) but should not have false positives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
