xiangfu0 commented on code in PR #11332:
URL: https://github.com/apache/pinot/pull/11332#discussion_r1292897152
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -238,6 +240,11 @@ public List<String> getTableNamesForQuery(String sqlQuery)
{
Set<String> tableNames =
RelToPlanNodeConverter.getTableNamesFromRelRoot(relRoot.rel);
return new ArrayList<>(tableNames);
} catch (Throwable t) {
+ String errorMessage = t.getMessage();
+ if (errorMessage.contains("Could not find schema for table: ")) {
Review Comment:
Another thought is to just do: https://github.com/apache/pinot/pull/11330
The whole query parsing here is just to fetch table names. If we use another
getTableNames method, then this problem is already gone.
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -238,6 +240,11 @@ public List<String> getTableNamesForQuery(String sqlQuery)
{
Set<String> tableNames =
RelToPlanNodeConverter.getTableNamesFromRelRoot(relRoot.rel);
return new ArrayList<>(tableNames);
} catch (Throwable t) {
+ String errorMessage = t.getMessage();
+ if (errorMessage.contains("Could not find schema for table: ")) {
Review Comment:
Another thought is to just do merge:
https://github.com/apache/pinot/pull/11330 then rebase.
The whole query parsing here is just to fetch table names. If we use another
getTableNames method, then this problem is already gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
