xiangfu0 commented on code in PR #11334:
URL: https://github.com/apache/pinot/pull/11334#discussion_r1294234242
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -66,13 +67,19 @@ public void send(TransferableBlock block)
}
Preconditions.checkState(!_statusObserver.isFinished(), "Mailbox: %s is
already closed", _id);
_contentObserver.onNext(toMailboxContent(block));
+ _isEarlyTerminated = _statusObserver.isFinished();
Review Comment:
removed
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/SendingMailbox.java:
##########
@@ -50,6 +50,11 @@ void send(TransferableBlock block)
*/
void complete();
+ /**
+ * Returns true if the mailbox has been early terminated. This can happen if
the receiver has cancelled the mailbox
+ */
+ boolean isEarlyTerminated();
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
