Jackie-Jiang commented on code in PR #11351:
URL: https://github.com/apache/pinot/pull/11351#discussion_r1295050355
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ArrayLiteralTransformFunction.java:
##########
@@ -218,7 +218,33 @@ public int[][] transformToIntValuesMV(ValueBlock
valueBlock) {
int[][] intArrayResult = _intArrayResult;
if (intArrayResult == null || intArrayResult.length < numDocs) {
intArrayResult = new int[numDocs][];
- Arrays.fill(intArrayResult, _intArrayLiteral);
+ if (_intArrayLiteral != null) {
Review Comment:
We want to set `_intArrayLiteral` only once, same for other places
```suggestion
if (_intArrayLiteral == null) {
switch (_dataType) {
case LONG:
...
}
}
Arrays.fill(intArrayResult, _intArrayLiteral);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
