Jackie-Jiang commented on code in PR #10927:
URL: https://github.com/apache/pinot/pull/10927#discussion_r1296154283
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##########
@@ -60,29 +64,57 @@ public PartialUpsertHandler(Schema schema, Map<String,
UpsertConfig.Strategy> pa
* For example, overwrite merger will only override the prev value if the
new value is not null.
* Null values will override existing values if not configured. They can be
ignored by using ignoreMerger.
*
- * @param previousRecord the last derived full record during ingestion.
+ * @param indexSegment the segment of the last derived full record during
ingestion.
+ * @param docId the docId of the last derived full record during ingestion
in the segment.
* @param newRecord the new consumed record.
- * @return a new row after merge
*/
- public GenericRow merge(GenericRow previousRecord, GenericRow newRecord) {
- for (String column : previousRecord.getFieldToValueMap().keySet()) {
+ public void merge(IndexSegment indexSegment, int docId, GenericRow
newRecord) {
Review Comment:
Good call. Added the label.
This is kind of intentional to ensure the old method is not used, but we
should be more careful and call it out explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
