Jackie-Jiang commented on code in PR #11358:
URL: https://github.com/apache/pinot/pull/11358#discussion_r1297490683
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -240,6 +241,17 @@ private TableDataManager createTableDataManager(String
tableNameWithType, TableC
@Override
public void deleteTable(String tableNameWithType)
throws Exception {
+
+ _tableDataManagerMap.compute(tableNameWithType, (k, v) -> {
Review Comment:
(MAJOR) This will break. We cannot use `compute()` here because it will
remove the entry from the map. Use `get()` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
