Jackie-Jiang commented on issue #11361: URL: https://github.com/apache/pinot/issues/11361#issuecomment-1682829449
Agree in regular case we should not catch throwable, but in the above stack trace, the throwable is caught within a `Thread`, and we intentionally catch it so that the thread doesn't die silently (it won't be able to propagate it back to the main thread even if we don't catch it). The best practice is to add JVM flag `ExitOnOutOfMemoryError` or `CrashOnOutOfMemoryError` so that it can exit regardless of where the error is triggered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
