Jackie-Jiang commented on code in PR #11348:
URL: https://github.com/apache/pinot/pull/11348#discussion_r1297647313
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/BaseDistinctAggregateAggregationFunction.java:
##########
@@ -147,7 +149,7 @@ protected void svAggregate(int length,
AggregationResultHolder aggregationResult
// For dictionary-encoded expression, store dictionary ids into the bitmap
Dictionary dictionary = blockValSet.getDictionary();
- if (dictionary != null) {
+ if (dictionary != null && !_nullHandlingEnabled) {
Review Comment:
That is not true here. We won't add null values into the set, so the one
added to the set is guaranteed to be `Integer.MIN_VALUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
