shenyu0127 commented on PR #11395: URL: https://github.com/apache/pinot/pull/11395#issuecomment-1686753556
> > > > Without this PR, the query `SELECT CASE WHEN boolCol = true THEN 'Yes'` also returns NULL if `boolCol` is NULL or false. Is the purpose of this PR only to improve performance? If that's the case, we can simply re-enable the ignored query. > > > > > > > > > Initially, when I started looking a couple of months back, it was an issue, but as of now, it is more or less a performance improvement and enabling the ignored queries. Please let me know if we can drop the performance improvement changes. Thanks > > > > > > I see. Please drop the performance improvement changes. > > Just out of curiosity, any particular reason for not having the performance logic? We prefer one PR to do one simple thing. - If it's to fix the bug and re-enable the ignored query, the two changes are closely related and can be put one PR. - If it's to improve performance and re-enable the ignored query, the two changes are not related and can be put in two PRs separately. Putting these two things in one PR causes confusion to the reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
