Jackie-Jiang commented on code in PR #11365:
URL: https://github.com/apache/pinot/pull/11365#discussion_r1300511610
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/VarianceAggregationFunction.java:
##########
@@ -134,12 +169,7 @@ public void aggregateGroupByMV(int length, int[][]
groupKeysArray, GroupByResult
@Override
public VarianceTuple extractAggregationResult(AggregationResultHolder
aggregationResultHolder) {
- VarianceTuple varianceTuple = aggregationResultHolder.getResult();
- if (varianceTuple == null) {
- return new VarianceTuple(0L, 0.0, 0.0);
- } else {
- return varianceTuple;
- }
+ return aggregationResultHolder.getResult();
Review Comment:
When null handling is disabled, we should not return `null` in the final
result though. We should apply the same logic as in `AvgAggregationFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
