This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c092b105e1 Fix a bug in SortOperator that prevents error block to be
propogated (#11425)
c092b105e1 is described below
commit c092b105e197b099bda18f28c1dbc91000bb0830
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Thu Aug 24 11:07:45 2023 -0700
Fix a bug in SortOperator that prevents error block to be propogated
(#11425)
---
.../org/apache/pinot/query/runtime/operator/SortOperator.java | 2 +-
.../java/org/apache/pinot/query/runtime/QueryRunnerTest.java | 9 ++++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git
a/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
b/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
index d80e41690c..d803848a7f 100644
---
a/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
+++
b/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java
@@ -152,7 +152,7 @@ public class SortOperator extends MultiStageOperator {
private void consumeInputBlocks() {
if (!_isSortedBlockConstructed) {
TransferableBlock block = _upstreamOperator.nextBlock();
- while (!block.isSuccessfulEndOfStreamBlock()) {
+ while (block.isDataBlock()) {
List<Object[]> container = block.getContainer();
if (_priorityQueue == null) {
// TODO: when push-down properly, we shouldn't get more than
_numRowsToKeep
diff --git
a/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java
b/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java
index 5b3e065543..55dbfac61c 100644
---
a/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java
+++
b/pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java
@@ -277,12 +277,19 @@ public class QueryRunnerTest extends QueryRunnerTestBase {
@DataProvider(name = "testDataWithSqlExecutionExceptions")
private Object[][] provideTestSqlWithExecutionException() {
return new Object[][]{
- // query hint with dynamic broadcast pipeline breaker should return
error upstream
+ // Missing index
+ new Object[]{
+ "SELECT col1 FROM a WHERE textMatch(col1, 'f') LIMIT 10",
+ "without text index"
+ },
+
+ // Query hint with dynamic broadcast pipeline breaker should return
error upstream
new Object[]{
"SELECT /*+ joinOptions(join_strategy='dynamic_broadcast') */ col1
FROM a "
+ " WHERE a.col1 IN (SELECT b.col2 FROM b WHERE
textMatch(col1, 'f')) AND a.col3 > 0",
"without text index"
},
+
// Timeout exception should occur with this option:
new Object[]{
"SET timeoutMs = 1; SELECT * FROM a JOIN b ON a.col1 = b.col1 JOIN
c ON a.col1 = c.col1",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
