shenyu0127 commented on code in PR #11444:
URL: https://github.com/apache/pinot/pull/11444#discussion_r1306693880
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java:
##########
@@ -257,6 +262,14 @@ public TransformResultMetadata getResultMetadata() {
return _resultMetadata;
}
+ private boolean isNotNullLiteralTransformation(TransformFunction function) {
Review Comment:
Prefer to name the function `isNullLiteralTransformation` to avoid potential
double negatives.
https://blog.devgenius.io/code-smell-51-double-negatives-993b6160f3e1
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LiteralTransformFunction.java:
##########
@@ -269,4 +269,9 @@ public RoaringBitmap getNullBitmap(ValueBlock valueBlock) {
bitmap.add(0L, length);
return bitmap;
}
+
+ // checks whether the literal is null or not.
Review Comment:
nit: The comment is redundant, it simply repeats what the function name says.
https://blog.boot.dev/clean-code/code-comments/
Section "AVOID REDUNDANT COMMENTS. STRIVE FOR A SINGLE SOURCE OF TRUTH"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
