xiangfu0 commented on code in PR #11452:
URL: https://github.com/apache/pinot/pull/11452#discussion_r1309075840
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -322,10 +321,9 @@ private void
assignWorkersToIntermediateFragment(PlanFragment fragment, Dispatch
}
}
if (serverInstances.isEmpty()) {
- LOGGER.error("[RequestId: {}] No server instance found for intermediate
stage for tables: {}",
+ LOGGER.info("[RequestId: {}] No server instance found for intermediate
stage for tables: {}, fall back to all",
Review Comment:
I think this check is actually correct.
Can we check before line 315 for table empty:
```
if (servers.isEmpty()) {
serverInstances = new ArrayList<>(enabledServerInstanceMap.values());
} else {
serverInstances = new ArrayList<>(servers.size());
for (String server : servers) {
ServerInstance serverInstance = enabledServerInstanceMap.get(server);
if (serverInstance != null) {
serverInstances.add(serverInstance);
}
}
}
```
Then you can
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
