Jackie-Jiang commented on code in PR #11466: URL: https://github.com/apache/pinot/pull/11466#discussion_r1311119135
########## pinot-common/src/test/java/org/apache/pinot/common/utils/request/RequestUtilsTest.java: ########## @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.utils.request; + +import org.apache.pinot.common.request.Expression; +import org.testng.Assert; +import org.testng.annotations.Test; + + +public class RequestUtilsTest { Review Comment: Suggest adding a query test. Currently it is not very clear why we need to do the conversion like this. Actually I don't know if always using double to strong float literal is correct ########## pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java: ########## @@ -192,7 +192,7 @@ public static Expression getLiteralExpression(Object object) { return RequestUtils.getLiteralExpression(((Number) object).longValue()); } if (object instanceof Float || object instanceof Double) { - return RequestUtils.getLiteralExpression(((Number) object).doubleValue()); + return RequestUtils.getLiteralExpression(Double.parseDouble(object.toString())); Review Comment: Separate `instanceof Float` and `instanceof Double`. We don't need to do this conversion for `Double`. Please also add some comment about why we need to do this conversion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
