xiangfu0 commented on code in PR #11502:
URL: https://github.com/apache/pinot/pull/11502#discussion_r1315100957
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -79,29 +79,27 @@ public static String upper(String input) {
/**
* @see String#substring(int)
* @param input Parent string
- * @param beginIndex index from which substring should be created
+ * @param beginIndex 1 based index from which substring should be created
* @return substring from beginIndex to end of the parent string
*/
@ScalarFunction(names = {"substr", "substring"})
Review Comment:
Shall we consider keep `substr` as current behavior and use `substring` for
postgresql behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
